Add `base64` gem dependency for Ruby 3.4 compatibility

SAML-Toolkits / ruby-saml

SAML SSO for Ruby

https://developers.onelogin.com/v1.0/page/saml-toolkit-for-ruby-on-rails

MIT License

897 stars 561 forks source link

Add `base64` gem dependency for Ruby 3.4 compatibility #680

Open casperisfine opened 3 months ago

casperisfine commented 3 months ago

I wanted to submit a PR but was a bit surprised with the gemspec and wasn't sure how to add a dependency in it.

So just a quick heads up that Ruby 3.4 will make base64 a "bundled gems", meaning gems now need to declare their dependency on it: https://bugs.ruby-lang.org/issues/20187

dentarg commented 2 months ago

Trying to simplify the gemspec in https://github.com/SAML-Toolkits/ruby-saml/pull/681

Since https://github.com/SAML-Toolkits/ruby-saml/commit/9b6e3e92dc21dd62439ebd63df722b6ffd43e391 the required Ruby version for ruby-saml is effectively Ruby 2.6.