SAML-Toolkits / wordpress-saml

OneLogin SAML plugin for Wordpress
MIT License
65 stars 75 forks source link

Variable name mismatch causing undefined variable warnings with SLO and WP_DEBUG #130

Open kshaner opened 2 years ago

kshaner commented 2 years ago

The variables $samlNameIdNameQualifier and $samlNameIdSPNameQualifier are defined at the top of the SLO login and never used within the saml_slo function.

Values ARE assigned to $nameIdNameQualifier and $nameIdSPNameQualifier but not previously defined.

https://github.com/onelogin/wordpress-saml/blob/e0e1e68dea4ba100f380efcd7c2331d379376867/onelogin-saml-sso/php/functions.php#L178-L205

I suspect these variables are intended to be the same. With WP_DEBUG on this breaks the SLO process with undefined variable warnings sent before headers are sent to the browser.