search

SAML-Toolkits / wordpress-saml

OneLogin SAML plugin for Wordpress
MIT License
65 stars 75 forks source link

include the core plugin files on the login page #135

Open gthayer opened 2 years ago

gthayer commented 2 years ago

Issue: https://github.com/onelogin/wordpress-saml/issues/129

Fixes the missing function error by including the WordPress core functions. I am not clear why newer versions of WP are breaking, but the root of the issue comes down to the plugin firing the is_plugin_active function before WordPress has loaded it.

Exordian commented 1 year ago

ping @pitbulk i hope it's fine to ping you. it would be awesome if you fine some minutes to review the open PRs including this one. the plugin works super fine for us. yet, we hope it does still work in the future (with more recent wordpress versions), hence taking a look on this would be very much appreciated

sandykadam commented 1 year ago

Yes please merge this PR, we need this fix for upgraded version where it is breaking.

pitbulk commented 1 year ago

Im trying to get privileges again on this and rest of SAML repos

tomasvanagas commented 1 year ago

Any progress on this?

mrmoss commented 1 year ago

@tomasvanagas - Still working on getting @pitbulk access. I wish I had a better answer 😞

pitbulk commented 1 year ago

@mrmoss any progress giving me access to WP plugin at Github and Wordpress site?

michael-sumner commented 6 months ago

I've filed a similar PR to address where the function does not need to exist and instead relies on the active_plugins option:

This fixes the issue with:

PHP message: PHP Fatal error:  Uncaught Error: Call to undefined function is_plugin_active() in /code/wp-content/plugins/onelogin-saml-sso/php/functions.php:108

Hope this helps!