SAML-Toolkits / wordpress-saml

OneLogin SAML plugin for Wordpress
MIT License
65 stars 74 forks source link

Ordering issue with Auth Check for SAML Validation #23

Closed argh128 closed 8 years ago

argh128 commented 8 years ago

The Auth Validation page /wp-login.php?saml_validate_config when not authenticated leaks information about the plugin configuration because the initial page content is sent before the 401 HEADER is marked.

https://github.com/onelogin/wordpress-saml/blob/master/onelogin-saml-sso/php/validate.php

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/wp-content/plugins/onelogin-saml-sso/php/validate.php:17) in /var/www/html/wp-content/plugins/onelogin-saml-sso/php/validate.php on line 20 Access Forbidden!