search

SAML-Toolkits / wordpress-saml

OneLogin SAML plugin for Wordpress
MIT License
65 stars 74 forks source link

Does not follow Wordpress plugin style. #3

Closed pitbulk closed 10 years ago

pitbulk commented 10 years ago

It's not really appropriate, in the WP context, to load a separate file first and then bootstrap WordPress from that file. In the plugin's php/settings.php:

require_once(dirname(dirname(dirname(dirname(dirname(FILE))))) . '/wp-load.php');

That's making a huge assumption about where to find the WP code. And this file is included in multiple places in the plugin (validate.php, metadata.php, functions.php, et al.).

Reported by Steelcase dev team.

pitbulk commented 10 years ago

Fixed 7c7040b64fe7a2d62cebec13b81667a2b711ee0b