search

SANBIBiodiversityforLife / nssl

GNU General Public License v2.0
1 stars 0 forks source link

Links to open on new page #72

Open rukayaj opened 6 years ago

rukayaj commented 6 years ago

I presume this is just the BA link in the footer? Don't think there are any other links? I will just and _parent="blank" to the a tag...

rukayaj commented 6 years ago

Ok following a phone conversation with Selwyn I now understand this to mean that he wants links within the justification paragraph to open on a new page. I'll need to do this with some javascript. Very low priority as I don't feel it adds anything to the site and I would personally find this functionality extremely annoying and I'm sure others would too based on google and smashing mag https://www.smashingmagazine.com/2008/07/should-links-open-in-new-windows/

reupost commented 6 years ago

Well, I guess its debatable, but even the article suggests: "It is appropriate to enforce opening links in a new window in case... the link leads to a non-html-document. E.g. .pdf-file, .xls-file, .mp3 and so on". Which these would be. But some sort of icon warning the user that this was going to happen would probably be good.

rukayaj commented 6 years ago

I'm pretty sure pdfs should open in a new window or offer a prompt to download anyway, by default browser behaviour? I understood from Selwyn it was external links to other websites which would be opening. I don't know. It feels like one of those things where people ask you to do it, and then a month later they ask you to undo it. And given that I'm not going to be here in a month perhaps it's best to be expedient? :smiley_cat:

reupost commented 6 years ago

Ah, ok. I think low priority for the moment, anyway :)