search

SANDAG / ABM

Sandag ABM
https://github.com/SANDAG/ABM/wiki
20 stars 21 forks source link

Shared cost factor only applied to parking cost #138

Open aber-sandag opened 2 months ago

aber-sandag commented 2 months ago

costFactorS2 and costFactorS3 are applied only to parking cost, should be applied to all auto costs for shared rides

https://github.com/SANDAG/ABM/blob/b8ed161d47ee3840c0b4e83976b26279bdbfd3a4/src/asim/configs/resident/trip_mode_choice.csv#L14

Also looks like cost_share_s2 and cost_share_s3 used for non-resident models has inconsistent value. cost_share_s2 is 2 in crossborder/constants.yaml but 0.57 in common/constants.yaml. As a result, shared 2 parking cost is currently divided by 0.57 in visitor model. (Value is overwritten with 2 for visitor but is inconsistent with tour mode choice, see replies)

https://github.com/SANDAG/ABM/blob/b8ed161d47ee3840c0b4e83976b26279bdbfd3a4/src/asim/configs/common/constants.yaml#L247

https://github.com/SANDAG/ABM/blob/b8ed161d47ee3840c0b4e83976b26279bdbfd3a4/src/asim/configs/visitor/trip_mode_choice.csv#L10

Shared cost factor appears to be missing completely from airport model

https://github.com/SANDAG/ABM/blob/b8ed161d47ee3840c0b4e83976b26279bdbfd3a4/src/asim/configs/common_airport/trip_mode_choice.csv#L27

aber-sandag commented 2 months ago

Visitor tour mode choice has shared cost factors set to 1, inconsistent with visitor trip mode choice where shared 2 parking cost is divided by 0.57

https://github.com/SANDAG/ABM/blob/ABM3_develop/src/asim/configs/visitor/tour_mode_choice_annotate_choosers_preprocessor.csv#L166

https://github.com/SANDAG/ABM/blob/ABM3_develop/src/asim/configs/visitor/tour_mode_choice.csv#L17

aber-sandag commented 2 months ago

Looks like the value of cost_share_s2 is overwritten in visitor trip_mode_choice.yaml, so visitor trip mode choice is being divided by 2, not by 0.57. Would still be good to update the value in common constants.yaml for consistency, and is still inconsistent with visitor tour mode choice

aber-sandag commented 2 months ago

We should also be splitting up TNC and Taxi costs per-passenger. Should this be done using the average occupancy for these modes?