161 remove tnc accessegress skims from the model

[aletzdy]

Proposed changes

Removing TNC access/egress skims from the model

Impact

This update will reduce model runtime and disk usage:

• Disk space reduced by about 54gb
• OMX skims: 10gb
• Emme transit database: 44gb
• ActivitySim skim buffer memory usage reduced by about 35gb
• Total runtime reduced by about 2 hours 20 minutes
  • Transit skimming: 9 min per iteration
  • Resident model mp_setup_skims: 5 min per iteration,
  • Additional resident model savings: 10-15 min per iteration (can't identify where, not visible in timing_log.csv)
  • Copy to T drive: 50 min

Types of changes

What types of changes does your code introduce to ABM? Put an x in the boxes that apply

• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Documentation Update (if none of the other choices apply)

How has this been tested?

Please describe the tests that you ran to verify your changes.

• [x] Model was run from to start to finish without error.

• [x] Model results were examined. VMT and ridership stayed similar, with only small differences.

  Checklist:

• [ ] My code follows the style guidelines of this project

• [x] I have performed a self-review of my own code

• [ ] I have commented my code, particularly in hard-to-understand areas

• [ ] I have made corresponding changes to the documentation

• [x] My changes generate no new warnings

Further comments

Code was reviewed by SANDAG staff.

[aber-sandag]

Visitor model trip mode choice preprocessor still references TNC skims. However, these lines (122-134) are no longer used, so it would be best to just remove them. Does not need to be part of this PR unless these lines result in errors with missing TNC skims.

https://github.com/SANDAG/ABM/blob/161-remove-tnc-accessegress-skims-from-the-model/src/asim/configs/visitor/trip_mode_choice_annotate_trips_preprocessor.csv#L122-L134

[aber-sandag]

TNC skims still referenced in write trip matrices annotator for crossborder and visitor models. These models do not use TNC-transit mode, so these lines are unused and should be removed. As above, does not need to be part of this PR unless it is causing errors.

https://github.com/SANDAG/ABM/blob/161-remove-tnc-accessegress-skims-from-the-model/src/asim/configs/crossborder/write_trip_matrices_annotate_trips_preprocessor.csv#L299

[aber-sandag]

TNC skims still referenced in write trip matrices annotator for crossborder and visitor models. These models do not use TNC-transit mode, so these lines are unused and should be removed. As above, does not need to be part of this PR unless it is causing errors.

https://github.com/SANDAG/ABM/blob/161-remove-tnc-accessegress-skims-from-the-model/src/asim/configs/crossborder/write_trip_matrices_annotate_trips_preprocessor.csv#L299

I ran a scenario with these changes, and it crashed in Crossborder due to this issue (AssertionError: 3d skim key TNCOUT_LOC_TOTALIVTT not in skims). Presumably all cases I mentioned previously where TNC skims are still referenced (though unused) need to be resolved. It should be possible to just remove these lines.

[aber-sandag]

After removing the mentioned lines, 2022 and 2035 build scenarios completed successfully. Did not find any clear differences in mode share compared to previous runs, though difficult to tell due to low volume of TNC transit trips.

• Disk space reduced by about 54gb
  • OMX skims: 10gb
  • Emme transit database: 44gb
• ActivitySim skim buffer memory usage reduced by about 35gb
• Total runtime reduced by about 2 hours 20 minutes
  • Transit skimming: 9 min per iteration
  • Resident model mp_setup_skims: 5 min per iteration,
  • Additional resident model savings: 10-15 min per iteration (can't identify where, not visible in timing_log.csv)
  • Copy to T drive: 50 min