The crossborder model had been reading a different constants.yaml file than the one in the common folder. This could lead to confusion as the two files have many of the same parameters defined (often with slightly different names), meaning that changes to the editing would need to be done twice. This pull request removes configs\crossborder\constants.yaml and edits the ActivitySim call in the crossborder model to read the configs from the common configs directory.
Impact
There should be no impact to the running of the model or on the results. The only impact should be on editing the configs, which will reduce the number of places where some settings need to be updated.
Types of changes
What types of changes does your code introduce to ABM?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
How has this been tested?
Please describe the tests that you ran to verify your changes.
[x] The crossborder model with these changes has been successfully run from Emme. Output files were created successfully and a check of the logfile revealed the correct land use file was read in. The run to test the change (C:\abm_runs\jflo\test_xborder_common_configs on Sparky) was copied from a full run (T:\STORAGE-63T\2025RP_init_concept\abm_runs_v7\2022_S0_v7), and the mode shares and average trip lengths were very close (differences likely due to skims being adjusted in final assignment and skimming of the full run).
[x] The scenario manager needed to be edited to remove references to the removed file and has been tested in Emme.
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
Proposed changes
The crossborder model had been reading a different constants.yaml file than the one in the common folder. This could lead to confusion as the two files have many of the same parameters defined (often with slightly different names), meaning that changes to the editing would need to be done twice. This pull request removes configs\crossborder\constants.yaml and edits the ActivitySim call in the crossborder model to read the configs from the common configs directory.
Impact
There should be no impact to the running of the model or on the results. The only impact should be on editing the configs, which will reduce the number of places where some settings need to be updated.
Types of changes
What types of changes does your code introduce to ABM? Put an
xin the boxes that applyHow has this been tested?
Please describe the tests that you ran to verify your changes.
Checklist: