search

SANDAG / ABM

Sandag ABM
https://github.com/SANDAG/ABM/wiki
20 stars 21 forks source link

Mode choice models not factoring in ebike ownership #97

Closed JoeJimFlood closed 6 months ago

JoeJimFlood commented 6 months ago

It looks as though ebike ownership is not properly incorporated into the mode choice models. The last line of the tour mode choice preprocessor adds a variable called ebike_owner to the choosers table, but it's set to just always be equal to zero. I did a quick check of some outputs to a run and it looks as though there's no difference in the ebike share based on ebike ownership.

aletzdy commented 6 months ago

fixed with two commits here and here.

JoeJimFlood commented 6 months ago

Should the ebike ownership be added in the preprocessor? The spec file calls for df.ebike_owner but the line that adds that to the tours table was taken out. Please let me know if I'm misunderstanding something.

aletzdy commented 6 months ago

The line that includes ebike_owner in the choosers' table is in the yaml file. If you check my first commit, we now include it in the choosers' table

JoeJimFlood commented 6 months ago

Sorry, I was confused a bit due to me misunderstanding how columns from other tables can be added using the logsum chooser columns. Thanks for clarifying!

JoeJimFlood commented 6 months ago

I checked the results of a model run and notices the ebike tour mode share was a bit higher for households owning ebikes than those that don't. Thanks!