SANdood / Ecobee-Suite

Ecobee Suite is for integrating Ecobee thermostats & sensors with the Hubitat home automation platform
108 stars 152 forks source link

Added support for Switch+ #44

Open dcmeglio opened 4 years ago

dcmeglio commented 4 years ago

I don't know if you'll be interested in merging this, but I added initial (Hubitat) support for Switch+'s. I know it's not thermostat related but the Hubitat default integration supports Switch+. I really didn't want to run two integrations (more hub resources used and I'm having 2 apps hit the Ecobee API). On top of this, your integration has MUCH better support for API disconnects and retries than the builtin Hubitat integration. So I figured I'd do it all through one app.

Some notes:

  1. Only tested on Hubitat
  2. I didn't even try to implement a ST tile as I have no way to test
  3. Tested both when only switches are setup, and switch + thermostat mode

It'd be great if you considered integrating it so I don't have to keep my fork in sync with your apps!

SANdood commented 4 years ago

Considering. I just ordered myself a switch...

Thanks! Barry

Sent from my iPhone

On Aug 7, 2020, at 6:49 PM, dcmeglio notifications@github.com wrote:

 I don't know if you'll be interested in merging this, but I added initial (Hubitat) support for Switch+'s. I know it's not thermostat related but the Hubitat default integration supports Switch+. I really didn't want to run two integrations (more hub resources used and I'm having 2 apps hit the Ecobee API). On top of this, your integration has MUCH better support for API disconnects and retries than the builtin Hubitat integration. So I figured I'd do it all through one app.

Some notes:

Only tested on Hubitat I didn't even try to implement a ST tile as I have no way to test Tested both when only switches are setup, and switch + thermostat mode It'd be great if you considered integrating it so I don't have to keep my fork in sync with your apps!

You can view, comment on, or merge this pull request online at:

https://github.com/SANdood/Ecobee-Suite/pull/44

Commit Summary

Initial work to support Switch+ devices Improved logging File Changes

A devicetypes/sandood/ecobee-suite-switch.src/ecobee-suite-switch.groovy (166) M smartapps/sandood/ecobee-suite-manager.src/ecobee-suite-manager.groovy (418) Patch Links:

https://github.com/SANdood/Ecobee-Suite/pull/44.patch https://github.com/SANdood/Ecobee-Suite/pull/44.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

esimioni commented 2 years ago

I've got a Switch+ recently and I'm very interested in this feature. Hubitat user here.