Exercise 22: Update Approuter version

SAP-archive / cloud-bulletinboard-ads

This is the bulletinboard-ads sample application code used in the openSAP course: Cloud-Native Development with SAP Business Technology Platform (formerly SAP Cloud Platform).

Apache License 2.0

76 stars 99 forks source link

Exercise 22: Update Approuter version #18

Closed nenaraab closed 4 years ago

nenaraab commented 5 years ago

Update version of approuter to 6.1.0

in .npmrc

package-lock=true
@sap:registry=https://npm.sap.com

Remove Node_modules from .cfignore

Further References:

https://docs.cloudfoundry.org/buildpacks/node/index.html#vendoring

frnksgr commented 5 years ago

If the version of approuter is updated, the rest of the turorial has to be checked, if it need to be adapted due to changes in approuter.
the point about package-lock and node_modules (not Node_modules) not in .cfignore is about vendoring your application on CF in order to provide strictly reproducible deployments. in the tutorial should be either a reference to vendoring or at least be mentioned that this is not a solution to be used poroductively.

nenaraab commented 4 years ago

Solution 22 updated to latest approuter version