search

SAP-archive / cloud-bulletinboard-ads

This is the bulletinboard-ads sample application code used in the openSAP course: Cloud-Native Development with SAP Business Technology Platform (formerly SAP Cloud Platform).
Apache License 2.0
76 stars 99 forks source link

Solution 24 make app secure spring5 #20

Closed hassler-d closed 4 years ago

hassler-d commented 4 years ago

This PR contains the migration path from spring 4 to spring 5 and adds security using spring-xsuaa.

hassler-d commented 4 years ago

I rebased the branch again so that it can be merged. I noticed that this logger dependency shows up as new: https://github.com/SAP-samples/cloud-bulletinboard-ads/pull/20/commits/71b7ff389fd7ef98d86a4673eed47e06728baecf#diff-600376dffeb79835ede4a0b285078036R186 Do you know where that came from? The sample works without it. Should I remove it?

nenaraab commented 4 years ago

I recognized it and didnt't understand... which version 1.5. is meant here... so, if it works without the dependency: pls remove it :-)

hassler-d commented 4 years ago

I recognized it and didnt't understand... which version 1.5. is meant here... so, if it works without the dependency: pls remove it :-)

I removed it. PR is now up to date.