SAP-archive / cloud-bulletinboard-ads

This is the bulletinboard-ads sample application code used in the openSAP course: Cloud-Native Development with SAP Business Technology Platform (formerly SAP Cloud Platform).
Apache License 2.0
76 stars 99 forks source link

Documentation improvement (exercise 3 all ads endpoint) #4

Closed mhnagaoka closed 6 years ago

mhnagaoka commented 6 years ago

On the week 2, unit 2 video, around 9:20, it's possible to see that the advertisements() method returns a AdvertisementList instead of Iterable<Advertisement> as stated on Exercise 3, Step 1.

Perhaps we could fix the base AdvertisementController implementation given on the exercise to include this class.

nenaraab commented 6 years ago

please see here (my comments to your pull request): https://github.com/SAP/cloud-bulletinboard-ads/pull/5