search

SAP-archive / cloud-bulletinboard-ads

This is the bulletinboard-ads sample application code used in the openSAP course: Cloud-Native Development with SAP Business Technology Platform (formerly SAP Cloud Platform).
Apache License 2.0
76 stars 99 forks source link

Exercise 16 / Step 5 - missing open Todo #8

Closed nenaraab closed 6 years ago

nenaraab commented 6 years ago

See also cp5 discussion: https://open.sap.com/courses/cp5/question/66e9a1c1-fa73-45c5-9e91-daf123da75fb

There was a missing openTodo...

I've tried to fix it, please review and follow up here!

skrishnakumar commented 6 years ago

fixed to-do with commit eb7e49d

nenaraab commented 6 years ago

@skrishnakumar Please double check on my commit, please :-)

skrishnakumar commented 6 years ago

@nenaraab i have checked the region and changed from eu10 to region. I have also added the comment at the beginning that region needs to be replaced. So, not sure what you want me to double check?

nenaraab commented 6 years ago

Dear Krishna, The commit, I've linked: https://github.com/SAP/cloud-bulletinboard-ads/commit/ecf8c71252cb9c62f9632df85222a0b65b82c53f :-)