SAP-archive / cloud-s4-sdk-pipeline-lib

The SAP Cloud SDK pipeline library defines essential functions for building cloud extension applications. The SAP Cloud SDK pipeline uses this library.
Apache License 2.0
27 stars 22 forks source link

Correct invalid default tmsUpload.namedUser #25

Closed laszloKajan closed 4 years ago

laszloKajan commented 4 years ago

tmsUpload.nameUser must conform to these requirements as reported by the TMService API:

{"message":"Request validation failed with 1 error(s): [Error in field: \u0027namedUser\u0027: \u0027Only Latin letters, numbers and following characters are allowed: \u0027_.-+\u0027, maximal length 60 characters\u0027; rejected value: \u0027CLOUD SDK PIPELINE\u0027]","errorType":"com.sap.lm.sl.alm.ts.core.exception.service.TsValidationException"}

The default should set a correct namedUser, e.g. 'CLOUD_SDK_PIPELINE'.

Context

Set a correct default tmsUpload.namedUser.

Definition of Done

Please consider all items and remove only if not applicable.

Merging

Please use squash merge and provide a good commit message, e.g. inspired by the context above. Make sure to remove the reference to this pull request and that this template is not part of the commit message. Also, please ensure the commit message is not just a list of "WIP" commit messages.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

laszloKajan commented 4 years ago

@daniel-kurzynski @fwilhe Dear Daniel and Florian! Could you please review this pull request? Thank you in advance. Best regards, Laszlo Kajan

fwilhe commented 4 years ago

Hi @laszloKajan

thanks for your contribution. Due to our process I can't directly merge your PR here, but I've triggered the process to merge your change.

fwilhe commented 4 years ago

Fixed in https://github.com/SAP/cloud-s4-sdk-pipeline-lib/commit/ea3644dfca79b75341938925721677db556bb27f (I'm sorry the attribution got lost in the process, I tried to preserve it)

laszloKajan commented 4 years ago

Thank you, @fwilhe !