SAP-archive / cloud-s4-sdk-pipeline

The Cloud SDK pipeline uses the Cloud SDK continuous delivery server for building, checking, and deploying extension applications. Projects based on the SAP Cloud SDK archetype will automatically use this pipeline.
Apache License 2.0
65 stars 25 forks source link

Do not hard-code pipelineSdkVersion in pipeline #28

Closed laszloKajan closed 4 years ago

laszloKajan commented 4 years ago

Do not hard-code pipelineSdkVersion in order to allow control of the version from -

Context

If applied, this commit will allow the control of the s4sdk-pipeline-library version from jenkins.yml, or 'Manage Jenkins / Configure System / Global Pipeline Libraries'.

Definition of Done

Please consider all items and remove only if not applicable.

Merging

Please use squash merge and provide a good commit message, e.g. inspired by the context above. Make sure to remove the reference to this pull request and that this template is not part of the commit message. Also, please ensure the commit message is not just a list of "WIP" commit messages.

fwilhe commented 4 years ago

Hi @laszloKajan

We have to ensure that the pipeline and the pipeline library version match, thus we need this. You can control the version in Jenkinsfile as described here. Does this not satisfy your needs?

laszloKajan commented 4 years ago

Dear Florian (@fwilhe ),

I was looking for a solution that would allow me to control the library version from the environment, without having to change 'pipelineSdkVersion' in s4sdk-pipeline.groovy (and therefore having to set my fork in the Jenkinsfile), but I accept your explanation of course.

Best regards, Laszlo