jung-thomas
commented
6 years ago This artifact won't work outside the SAP firewall. Actually it does work because this line is commented out.
[cid:image001.png@01D3ABDD.4A29C590]
It was left in so that SAP employees taking the course can adjust the exercise for usage internally. But if you require it to be removed I will do so.
Thomas Jung
From: Jonathan Baker [mailto:notifications@github.com] Sent: Thursday, February 22, 2018 12:54 PM To: SAP/com.sap.openSAP.hana5.example com.sap.openSAP.hana5.example@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [SAP/com.sap.openSAP.hana5.example] Internal SAP reference in settings files (#5)
The file httpclient.jshttps://github.com/SAP/com.sap.openSAP.hana5.example/blob/f74f54b52c50fcbd96eaba633d6049aa0ae744f6/core-js/async/httpClient.js contains a reference to an internal SAP server:
{path: "http://www.loc.gov/pictures/search/?fo=json&q=SAP&",
--
20 | host: "proxy.wdf.sap.corp",
21 | port: "8080",
22 | headers: {
Specifically, the server:
proxy.wdf.sap.corp
This artifact won't work outside the SAP firewall.
SAP Open Source runs regular scans looking for artifacts in the code which might indicate our internal code has accidentally released in to the Open Source stream. This file continues to show up in our scans. Can you please fix it, or remove it, so that it no longer shows up as an error?
Thank you.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/SAP/com.sap.openSAP.hana5.example/issues/5, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALmJfLR62Y3_eegbkoW1eD6HZ8Ak6Lqwks5tXanOgaJpZM4SPuhK.
jonathanbaker7
The file httpclient.js contains a reference to an internal SAP server:
Specifically, the server:
This artifact won't work outside the SAP firewall.
SAP Open Source runs regular scans looking for artifacts in the code which might indicate our internal code has accidentally released in to the Open Source stream. This file continues to show up in our scans. Can you please fix it, or remove it, so that it no longer shows up as an error?
Thank you.