Remove deprecated multiline dependency

SAP-archive / grunt-openui5

Grunt tasks around OpenUI5

Apache License 2.0

90 stars 34 forks source link

Remove deprecated multiline dependency #235

Closed fwilhe closed 2 years ago

fwilhe commented 2 years ago

The dependency had some use pre es 2015 but is not required since then and the author has deprecated it 4 years ago.

See issue https://github.com/SAP/grunt-openui5/issues/234

matz3 commented 2 years ago

Thanks. Don't worry about the coveralls status. The slight decrease is not an issue.

fwilhe commented 2 years ago

Yes, I just wanted to know where that "new line" comes from 😬

Just FYI I'm not that fond of (frontend) js/Grund, so I hope I did not unintentionally break anything. The change looked simple enough to me, but there might be things to watch out that I did not know about.

fwilhe commented 2 years ago

@matz3 Thanks for your review. Regarding the regex escape, I think I tried this and saw an error when running the tests, but I did not investigate that further. Not sure about the test coverage for this kind of change, on my machines the test worked in both cases, but I don't know the context of this code so I can't judge correctness.

matz3 commented 2 years ago

Thanks for the updates 👍🏻 I've manually tested the change as this part is not covered in the tests. The related script reloads stylesheets when running in watch mode so that theme changes can be made without doing a full page reload.

coveralls commented 2 years ago

Coverage decreased (-0.05%) to 81.967% when pulling 8de20e0a3c144820b124b841f4891efea423a02b on fwilhe:remove-multiline-dependency into d3f4b32f40b9f25aeb9973f8414b4fe64871c25d on SAP:master.

matz3 commented 2 years ago

Released with v0.18.3