search

SAP-archive / helm-broker

A Service Broker which exposes Helm charts as Service Classes in the Service Catalog
https://kyma-project.io/docs/components/helm-broker
Apache License 2.0
47 stars 21 forks source link

release-1.1 : missing slash in container registry path #178

Closed jixiangyiyi closed 3 years ago

jixiangyiyi commented 3 years ago

Description

Get below wrong docker images when doing deployment for release-1.1

eu.gcr.io/kyma-projecthelm-broker:v1.1.0 and eu.gcr.io/kyma-projecthelm-controller:v1.1.0

Expected result

eu.gcr.io/kyma-project/helm-broker:v1.1.0 and eu.gcr.io/kyma-project/helm-controller:v1.1.0

Actual result

eu.gcr.io/kyma-projecthelm-broker:v1.1.0 and eu.gcr.io/kyma-projecthelm-controller:v1.1.0

Steps to reproduce

➜ helm-broker git:(release-1.1) ✗ k create ns helm-broker ➜ helm-broker git:(release-1.1) ✗ helm upgrade helm-broker charts/helm-broker --install --namespace helm-broker

then get wrong docker images in pod

Troubleshooting

Add missing slash into https://github.com/kyma-project/helm-broker/blob/release-1.1/charts/helm-broker/values.yaml#L40

global:
  containerRegistry:
    path: eu.gcr.io/kyma-project/
PK85 commented 3 years ago

We do not work on Helm Broker actively, please consider contribution.