search

SAP-archive / karydia

Kubernetes Security Walnut
Other
76 stars 10 forks source link

Update Deployment Accordingly Kubernetes Version 1.16 #233

Closed Neumann-Nils closed 5 years ago

Neumann-Nils commented 5 years ago

Description

Kubernetes 1.16 changed the version for a deployment from extensions/v1beta1 to apps/v1 and requires a selector field. As Helm 2.15 was released, we should support the current Kubernetes version. This PR implements the needed changes.

Fixes #223. Fixes #232.

Checklist

Before submitting this PR, please make sure:

Neumann-Nils commented 5 years ago

Currently encountering problems with the development version. Need a deeper look.

Neumann-Nils commented 5 years ago

Using Helm 2.15 I encounter the following problem using the development version:

Error: render error in "karydia/templates/deployment.yaml": template: karydia/templates/deployment.yaml:48:17: executing "karydia/templates/deployment.yaml" at <gt .Values.dev.timeoutIncreaseValue 0.0>: error calling gt: incompatible types for comparison

A workaround could be to delete the according lines for now, as there seem to be some problems with numeric values in the new Helm release (https://github.com/karydia/karydia/issues/234).

When applying the above workaround and deploying Karydia using Helm 2.15, the pod won't start due to the following error:

ERROR binary not found: Is 'dlv --listen=:2345 --headless=true --api-version=2 --accept-multiclient exec {{binPath}} --' an absolute path to an existing binary?

Using an older version of Helm (e.g. 2.14) the problem does not occur.

@karydia/karydia-maintainers does anyone know what is might causing this problem?

Neumann-Nils commented 5 years ago

I introduced the workaround (deleting the according lines) for the first problem.

The second problem seems to be connected to the Go version. As Helm 2.15 upgraded to Go version 1.13.3 and we were still on 1.12.9, this caused some problems. I updated the version and seems to work fine now.