search

SAP-archive / karydia

Kubernetes Security Walnut
Other
77 stars 10 forks source link

Add files for dev setup #61

Closed ionysos closed 5 years ago

schu commented 5 years ago

Note that we use hack/ for Kubernetes code-generate scripts only currently and our scripts did go into scripts/ so far.

Could you add a commit message where you explain the motivation and goal of the change? From a short look on the code, I feel this is hard to see through for outsiders and I'm not sure about the approach (for example, using a different base image for development containers and thus having less homogeneous setups).

Thanks :)

schu commented 5 years ago

Regarding hotswap, can we maybe use e.g. https://github.com/fvbock/endless instead (i.e. make this a built-in feature)?

ionysos commented 5 years ago

Regarding hotswap, can we maybe use e.g. https://github.com/fvbock/endless instead (i.e. make this a built-in feature)?

@schu thx for the hint. we already evaluated some of this solutions but all of these seem a little bit overloaded for our use case. I think we should try this 'solution' first because it's just for our development setup (not for our target customers or production deployments).

ionysos commented 5 years ago

Note that we use hack/ for Kubernetes code-generate scripts only currently and our scripts did go into scripts/ so far.

Could you add a commit message where you explain the motivation and goal of the change? From a short look on the code, I feel this is hard to see through for outsiders and I'm not sure about the approach (for example, using a different base image for development containers and thus having less homogeneous setups).

Thanks :)

Detailed commit message added.

schu commented 5 years ago

In general I like the idea of having a mechanism to reload karydia in-place, but the PR is not in a state to be generally useful IMHO and I think we should not merge it here.

In a nutshell,