search

SAP-archive / yaas_java_jersey_wishlist

Due to the retirement of YaaS, this repository is archived and will no longer be maintained. --- This is an example implementation of the YaaS "Wishlist" service based on Java. It uses the RAML definition generated by the SDK without modifications. It shows how to implement a basic service and how to integrate with other services on YaaS.
Apache License 2.0
16 stars 19 forks source link

STA-3353 update libraries and documentation #24

Closed reinhard-maier closed 7 years ago

a-thaler commented 7 years ago

Hi Reinhard, thanks for providing the pull request, looks good in general. However, besides that we recommend to use environment variables, it still should work with default.properties. There is a fallback chain described in the default.properties and for me it sounds like that this is not working anymore. Can you please check that as well and either fix the chain or remove the related descriptions in the properties files. Thanks, Andreas

reinhard-maier commented 7 years ago

Hi Andreas, I verified the configuration in default.properties and overriding in system properties, environment and test.properties. The documentation is still correct. Thanks, Reinhard

a-thaler commented 7 years ago

@reinhard-maier Am asking as in the issue description it is said that it is not working with providing the credentials to the properties: https://github.com/SAP/yaas_java_jersey_wishlist/issues/23

Furthermore please consider the feedback from @williamkeyes

reinhard-maier commented 7 years ago

@a-thaler now, the documentation should be clear enough to avoid using a manifest with invalid environment entries. Thereby, the issue should be solved.