SAP-docs / btp-cloud-platform

Markdown source for the SAP BTP documentation. Enables feedback and contributions to improve the documentation.
Creative Commons Attribution 4.0 International
50 stars 95 forks source link

Feedback for "Environment Variables" #156

Closed szymarcus closed 1 year ago

szymarcus commented 1 year ago

https://help.sap.com/docs/btp/sap-business-technology-platform/environment-variables#httpheaders

Hey,

I deployed the httpHeaders like so:

image

After checking the response I dont see any Content-Security-Policy nor X-Frame-Options headers. Also I am not sure if static routes are covered by the headers as well when I deploy them with the app service.

Thanks in advance.

Regards Marcus

nikolasimeonov77 commented 1 year ago

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

SarahErdmann commented 1 year ago

Hello @szymarcus,

Unfortunately, we do not understand what went wrong. The configuration of the httpHeaders should normally work as described here on the Help Portal: httpHeaders

Did you add the httpHeaders environment variables to the application router or to the backend application? (CDS_CONFIG is not a known application router environment variable.)

Are you using an application router managed by SAP (provided by SAP Cloud Portal or SAP Build Work Zone, standard edition or advanced edition)?

Best regards, Sarah

szymarcus commented 1 year ago

Hello Sarah,

thanks for your quick reply.

I am using the managed app router from SAP Build Work Zone, standard edition. Trying to add the config it states

cf set-env <myApp> httpHeaders "[ { \"X-Frame-Options\": \"ALLOW-FROM http://acme.com\" }, { \"Test-Additional-Header\": \"1\" } ]"

this command. <myApp> can only be filled with my backend service though which does not make sense imo when I try to configure the app router. On the other hand I have no idea how to configure the managed app router. Do you have an idea how I can set the config for the managed app router? I imagine that this is not possible since other apps also use it in our sub account.

SarahErdmann commented 1 year ago

Hi @szymarcus,

If you are using the managed application router, you can configure response headers in the routing configuration file (xs-app.json file). This is described here in the documentation for SAP Build Work Zone, standard edition: responseHeaders (Or here in the SAP BTP devloper guide: responseHeaders ).

Best regards, Sarah

nikolasimeonov77 commented 1 year ago

Hi there 👋 There's been no activity on this issue for a while, so we're closing it. If you've further information to provide, please comment below and add that information. We'll review it and reopen the conversation if necessary. Until next time, thanks!

sap-doc-bot[bot] commented 1 year ago

Thank you for your valuable feedback contribution, @szymarcus! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!