SAP-docs / btp-cloud-platform

Markdown source for the SAP BTP documentation. Enables feedback and contributions to improve the documentation.
Creative Commons Attribution 4.0 International
51 stars 99 forks source link

Application Security Descriptor Configuration Syntax is missing Role Collection configuration #237

Closed sebastianesch closed 1 month ago

sebastianesch commented 1 month ago

Issue description

Hi,

the chapter describing the xs-security.json syntax does not cover role collections. There is an example how to include role collections available here: https://help.sap.com/docs/btp/sap-business-technology-platform/create-role-collections-with-predefined-roles

But it would be nice, if the role collection part would also be described in the general reference for the Application Security Descriptor and not only in the Tasks on Demand section. It would also be nice to describe all elements of the role collection definition if there are more then the ones used in the example.

Kind regards, Sebastian

Feedback Type (Optional)

content gaps

Page Title on SAP Help Portal (prefilled)

Application Security Descriptor Configuration Syntax

Page URL on SAP Help Portal (prefilled)

https://help.sap.com/docs/btp/sap-business-technology-platform/application-security-descriptor-configuration-syntax

sebastianesch commented 1 month ago

Actually I just noticed, that the role-collection information is already there but not included in the example at the top of the page where you can navigate to the different sections. I did not notice the point "role-collection" in the right navigation ("On this page").

From my point of view, adding role collections to the example makes it easier to find the section at the bottom of the page.

PlamiIG commented 1 month ago

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

mar-blu commented 1 month ago

Hello Sebastian,

I am going to look into your request.

For the time being, I recommend to use the blog on the Authorization and Trust Management product page. Blog: https://community.sap.com/t5/technology-blogs-by-sap/creating-role-collections-in-sap-btp-using-the-new-role-collections/ba-p/13404427

mar-blu commented 1 month ago

Your suggestion to include the role-collection example into the first central example makes sense. However, such a change has low priority.

I created a related backlog item. See https://jira.tools.sap/browse/SECDOC-1931

mar-blu commented 1 month ago

I created a related backlog item. See https://jira.tools.sap/browse/SECDOC-1931

sap-doc-bot[bot] commented 1 month ago

Thank you for your valuable feedback contribution, @sebastianesch! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

mar-blu commented 1 month ago

The "role-collections" example will be available with an upcoming help portal delivery.