SAP-docs / btp-cloud-platform

Markdown source for the SAP BTP documentation. Enables feedback and contributions to improve the documentation.
Creative Commons Attribution 4.0 International
47 stars 88 forks source link

Feedback for "Add Custom SOAP Header Elements" #49

Closed gpaliot-eurosec closed 2 years ago

gpaliot-eurosec commented 2 years ago

Hi,

regarding https://help.sap.com/products/BTP/65de2977205c403bbc107264b8eccf4b/3dadfa903a11457d92248bccaa44fa27.html?locale=en-US&version=Cloud

I think there's a typo in the example:

ws_header_facade->add_soap_header_element( xml_element).

should be

ws_header_facade->add_soap_header_element( xml_element ).

otherwise I get a syntax check error in ADT, saying

_The statement concluding with "...XMLELEMENT)" ended unexpectedly.

Best regards

Guido

felixdraeger commented 2 years ago

Hello Guido, thank you for your feedback. I will check this issue with the responsible development colleagues.

Kind regards Felix

sap-doc-bot[bot] commented 2 years ago

Thank you for your valuable feedback contribution, @gpaliot-eurosec! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

felixdraeger commented 2 years ago

Hi Guido, I've updated the example. Thanks for the contribution. You will be able to see the change on SAP Help Portal after the next content update.