search

SAP-docs / sap-artificial-intelligence

Markdown source for the SAP AI documentation. Enables feedback and contributions to improve the documentation.
Creative Commons Attribution 4.0 International
2 stars 9 forks source link

AI Core - Git Onboarding #18

Open lechnerc77 opened 6 months ago

lechnerc77 commented 6 months ago

Issue description

The section title gives the reader the impression that the generic onboarding of Git repositories independent of the Git offering is described. The text is then more focusing on GitHub, mentions GitLab once, but leaves out GitLab specifics.

The section should clearly state which offerings are supported and then describe the onboarding steps per offering.

In addition, recommending the usage of a PAT is questionable from different aspects. At least for GitHub there should be a GitHub app offered to facilitate the authentication, as the PAT is always bound to a user and that is probably not a good approach in an enterprise context.

Feedback Type (Optional)

other

Page Title on SAP Help Portal (prefilled)

Add a Git Repository

Page URL on SAP Help Portal (prefilled)

https://help.sap.com/docs/sap-ai-core/sap-ai-core-service-guide/register-your-git-repository-and-secrets?version=CLOUD

karu-0711 commented 6 months ago

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.