search

SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
71 stars 116 forks source link

[doc issue] #103

Closed biscimus closed 5 months ago

biscimus commented 6 months ago

Issue description

The hyperlinks in the manifest.json documentation are all wrong!!

Feedback Type (Optional)

linking

Page Title on SAP Help Portal (prefilled)

No response

Page URL on SAP Help Portal (prefilled)

No response

BorisDafov commented 6 months ago

Hi biscimus, thanks for your feedback. I have now checked several hyperlinks in the manifest.json documentation but couldn't find any wrong. Could you please give an example? Thank you!

ziyang-works commented 6 months ago

UPDATE: the issue for me seems like a duplication of https://github.com/SAP-docs/sapui5/issues/101 The issue only occurs when I open those links in a new page.

Hi @BorisDafov , I'm facing the same issue with manifest.json documentation as well as several other pages.

Manifest.json doc I'm having issue with: https://sapui5.hana.ondemand.com/sdk/#/topic/be0cf40f61184b358b5faedaec98b2da

Example non-working hyperlink: No Namespace

Screenshot:

image

After clicking:

image

Seems the link only works after replacing sdk/topic with sdk/#/topic

Other non-working hyperlinks:

I'm not sure if these links need to be fixed manually one by one. If yes, I would love to submit PRs for fixing links next time.

sap-doc-bot[bot] commented 5 months ago

Thank you for your valuable feedback contribution, @biscimus! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

OlMue commented 5 months ago

Hi @biscimus, we have reproduced and identified the error. It will be fixed as soon as possible. Thanks for your contribution!