SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
71 stars 116 forks source link

Fiori Elements - v4 FCL defaultLayoutType #118

Closed mzinnoecker closed 2 months ago

mzinnoecker commented 2 months ago

Issue description

The page Enabling the Flexible Column Layout mentions the possibility for adding defaultLayoutType in v2 apps. It would be nice mentioning defaultLayoutTypeIfExternal for v2 apps too.

Nevertheless, i was searching where to place the attributes in a v4 app. The description for v4 is missing, or the feature may not exist yet. More specifically, i needed the attribute defaultLayoutTypeIfExternal for an v4 app. If it's not possible yet, i think it would be nice mentioning it that this is not supported.

Thanks for checking! Best Regards, Michael

Feedback Type (Optional)

content gaps

Page Title on SAP Help Portal (prefilled)

Enabling the Flexible Column Layout

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/sdk/#/topic/e762257125b34513b0859faa1610b09e.html

KvM2 commented 2 months ago

Hi @mzinnoecker , thanks for your contribution . We appreciate it and will look into this.

JannaLisa commented 2 months ago

Hello @mzinnoecker , I'm checking with one of our developers how to best close this gap. Please be patient, we're already investigating!

JannaLisa commented 2 months ago

Hi again, @mzinnoecker, We've checked and are wondering if we didn't quite understand your query correctly. Our documentation for Fiori elements always follows the same pattern: the generic features applicable to both V2 and V4 are described at the beginning. Then, when the fine tuning begins and there are slight differences in the approach or the code, we have separate sections for V2 and V4. I admit that in the V4 section we don't have a parallel section to Defining a Default Layout. But we do explain how you need to proceed: In "routing.config", the optional "flexibleColumnLayout" object allows you to specify the default expansion of the columns to two columns and three columns layout. Regarding your request for the attribute defaultLayoutTypeIfExternal: I'm afraid the developer doesn't understand what you mean. Could you please clarify?

mzinnoecker commented 2 months ago

Hello @JannaLisa thanks for your answer. Let me try to explain what i meant initially.

1) From a readers perspective i would have expected to highlight for an v4 App that its currently not supported to refine the defaultLayoutType per page. That means, if i have a global setting „TowColumnsBeginExpanded“ for two columns layout, i am not allowed to override it to „TwoColumnsMidExpanded“ for only page XY. Would have been quite nice to explicitly mention this is not supported currently in v4, as there is no „pages“ property as from my understanding. Do you agree on that?

2) i do use the property defaultLayoutTypeIfExternal quite often, see here for the details

Default layout used to open the corresponding page in FlexibleColumnLayout when reached via external navigation

coming from externally and calling the fiori elements app with a specific hash/route/url parameters i am allowed to directly jump into „MidColumnFullScreen“ without rendering the List initially. Thats quite nice to reuse the same app from external. I cannot see how this can be achieved with a v4 app, as for the same reason as in 1): there is no pages property. Again, it would have been nice to highlight that for v2 and for v4 (or maybe i am something missing)

thanks!, Michael

JannaLisa commented 2 months ago

Hi @mzinnoecker , Thanks for explaining. Regarding point 1: you are correct, V4 does not support this. And that's why we don't mention it in the documentation. We usually explain features we support. We don't list (all) the features we don't support. So you are correct in pointing out there's a gap between V2 and V4. Regarding point 2: again, this property is supported in V2, but not in V4. I asked the PO for V4 and he will check whether this could be a requirement/gap we can close. So for now, I'm afraid there's nothing more I can do. I hope you understand. Thanks!

mzinnoecker commented 2 months ago

Thanks! Best, Michael