SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
71 stars 116 forks source link

Update table-groupings-d344c5a.md #123

Closed sani2608 closed 1 month ago

sani2608 commented 1 month ago

typo fix

cla-assistant[bot] commented 1 month ago

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

sap-doc-bot[bot] commented 1 month ago

Thank you for your valuable content contribution, @sani2608! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

OlMue commented 1 month ago

Hi @sani2608, thanks for your contribution! We're on it.

sani2608 commented 1 month ago

Thank you for your valuable content contribution, @sani2608! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

831978

KaijaInga commented 1 month ago

Hi @sani2608 , the changes have been made, you can see them on Help Portal: https://help.sap.com/docs/SAPUI5/96880755e4e64fcd96c12694f430fece/d344c5aa5c81483482dbbed5b3abb142.html?state=DRAFT&q=table%20groupings Please check if everything's alright on your end and let me know if there's anything else we should check. If not, please close this pull request. Thank you!

OlMue commented 1 month ago

@KaijaInga, thanks! Just to let you know: Contributors from outside SAP can't access the draft Help Portal link you provided.

Since you corrected the typo, you can now merge this PR. external contributors don't have this authorization, and merging is the last step if we have accepted a contribution. Thanks! :-)

KaijaInga commented 1 month ago

Thanks, @OlMue ! I can't merge, though... image

OlMue commented 1 month ago

Hi @KaijaInga, right, I need to check your authorizations, sorry. I merged the PR in the meantime.