search

SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
71 stars 116 forks source link

The dialog is new but not highlighted as such #127

Closed o-liver closed 1 month ago

o-liver commented 1 month ago

In the code changes for the webapp/controller/HelloPanel.controller.ts the private dialog: Dialog; statement is not highlighted in yellow, even though it is a new change in regards to the previous step.

https://github.com/SAP-docs/sapui5/blame/e91c998501a959ac766536e81a537ea6916bec80/docs/03_Get-Started/step-16-dialogs-and-fragments-typescript-4b2e306.md#L75

KvM2 commented 1 month ago

Hi @o-liver, thanks for your contribution! We'll look into it and will get back to you.

KlattG commented 1 month ago

Fixed from UI5 1.125