Using Dialogs Defined as Fragments errors in fiori element controller extension

SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.

Creative Commons Attribution 4.0 International

92 stars 144 forks source link

Using Dialogs Defined as Fragments errors in fiori element controller extension #135

Closed horsemanjackyliu closed 5 months ago

horsemanjackyliu commented 5 months ago

Issue description

https://sapui5.hana.ondemand.com/#/topic/aeb86c181b9742a2bf88049abf9ccb95 When loadFragment , the result is undefined . But in network , the result is 200.

The sap ui5 version is 1.124.1 .

But when the sap ui5 is 1.120.8, the function works in BAS, but after deployed into BTP ABAP environment, it fails again .

Feedback Type (Optional)

None

Page Title on SAP Help Portal (prefilled)

No response

Page URL on SAP Help Portal (prefilled)

No response

OlMue commented 5 months ago

Hi @horsemanjackyliu thanks for your feedback. We'll take a look and get back to you. @KlattG , could you please check (possibly with the devs) if this a documentation issue at all?

horsemanjackyliu commented 5 months ago

Hi, Mueller,

i think one possible reason is @sap/ux-specification latest version is 1.120.12 . So if the UI5 version is higher than this, some issue will happens. https://www.npmjs.com/package/@sap/ux-specification

devtomtom commented 5 months ago

Hi @horsemanjackyliu, Thank you for your feedback. We need to look into this issue in more detail as it is rather technical. Please report an incident at https://me.sap.com. Best regards!

boghyon commented 5 months ago

@horsemanjackyliu

https://sapui5.hana.ondemand.com/#/topic/aeb86c181b9742a2bf88049abf9ccb95 When loadFragment , the result is undefined .

The loadFragment API referred in the above linked documentation is from sap.ui.core.mvc.Controller#loadFragment.
The loadFragment API from the screenshot is from Fiori elements: sap.fe.core.ExtensionAPI#loadFragment. This is an entirely different API with the same name.

To see which SAPUI5 version the app is running with, set the focus on the app UI (not the shell header) and press Ctrl+Shift+Left Alt / Left ⌥+P.

horsemanjackyliu commented 5 months ago

Boghyon,

You are right! The loadFragment API from the screenshot is from Fiori elements sap.fe.core.ExtensionAPI#loadFragment. I use SAPUI5 version 1.120.8 in BAS, the issue is overcomed . But after I deploy the Fiori application into BTP ABAP environment. The issue happens again .

Best regards! Jacky Liu

horsemanjackyliu commented 5 months ago

Boghyon, But I think the issue exists in SAP UI5 version which is after 1.121 .

Best regards!

Jacky Liu

horsemanjackyliu commented 5 months ago

Boghyon, Is it possible to forward the issue to Fiori elements sap.fe.core.ExtensionAPI#loadFragment PM team .Or provide a contact to me . Best regards!

Jacky Liu