SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
90 stars 142 forks source link

docs(FE): Fix CAP CDS annotation for LineItem #137

Closed bugwelle closed 4 months ago

bugwelle commented 4 months ago

A single quote was missing in the snippet.

cla-assistant[bot] commented 4 months ago

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] commented 4 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

OlMue commented 4 months ago

Hi @bugwelle, thanks a lot for pointing this out. We're on it.

mishuagrawal commented 4 months ago

Hello @bugwelle,

Thank you for reaching out to us. I have now corrected the document and the change should start reflecting with our upcoming release. Please let us know if there is anything else we can help you with.

Thanks and regards, Mishu Agrawal

bugwelle commented 4 months ago

Thanks, @mishuagrawal . I take it that the change is handled outside of this PR and I can close it? :)

mishuagrawal commented 4 months ago

Hello @bugwelle, yes you are right. I have already fixed the document but the change reflection will take some time. If its alright with you, I can go ahead and merge this PR.

Please let me know. Thank you!

bugwelle commented 4 months ago

@mishuagrawal Thanks! Whatever suites you best. If you can merge it, that'd be great. :)

mishuagrawal commented 4 months ago

Hello @bugwelle,

Thank you for your confirmation. I will go ahead and merge the PR.

sap-doc-bot[bot] commented 4 months ago

Thank you for your valuable content contribution, @bugwelle! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

bugwelle commented 4 months ago

264793