search

SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
79 stars 126 forks source link

HTML in <code> tags not escaped properly #17

Closed mbtools closed 1 year ago

mbtools commented 1 year ago

The following page contains &nbsp; in the sentence Trailing spaces in text lines are escaped with in the respective BSP pages..

https://github.com/SAP-docs/sapui5/blob/main/docs/05_Developing_Apps/technical-remarks-5a814d9.md

The markdown is correct. However, it's not rendered right:

https://sapui5.hana.ondemand.com/#/topic/5a814d9945d148b0a1ad941791c3c723

The following is not correct:

<code>&nbsp;</code>

The content of the <code> tags must be escaped at render. It should be:

<code>&amp;nbsp;</code>

Please fix the markdown renderer.

DavidMitreski5 commented 1 year ago

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

OlMue commented 1 year ago

Hi @mbtools Thanks for spotting this! For some background: The source both for https://sapui5.hana.ondemand.com/#/topic/5a814d9945d148b0a1ad941791c3c723 and for technical-remarks-5a814d9.md is a DITA XML file from our content management system. There's no MD renderer involved here.

But something is obviously going wrong between the DITA XML file and the HTML at https://sapui5.hana.ondemand.com/#/topic/5a814d9945d148b0a1ad941791c3c723. We're going to check that.

Thanks!

OlMue commented 1 year ago

Thanks again @mbtools! This will be fixed as of 1.110.

sap-doc-bot[bot] commented 9 months ago

Thank you for your valuable feedback contribution, @mbtools! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

mbtools commented 9 months ago

https://people.sap.com/marcbernardtools