SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
72 stars 119 forks source link

Add missing return statement in setValue #41

Closed andre-schaerpf closed 1 year ago

andre-schaerpf commented 1 year ago

All automatically generated setter methods return this to allow method chaining. This is true for any given SAPUI5 control and is automatically done by ManagedObject. However, this custom control implementation does not comply with this behavior.

This commit adds the missing return statement in setValue to comply with the behavior of other SAPUI5 controls.

cla-assistant[bot] commented 1 year ago

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

DavidMitreski5 commented 1 year ago

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

KlattG commented 1 year ago

Need to adapt both code and dev guide.