SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
72 stars 119 forks source link

Code sample full of ` ` #45

Closed marianfoo closed 1 year ago

marianfoo commented 1 year ago

https://sapui5.hana.ondemand.com/sdk/#/topic/02fb273ee1024fec914b11befe2b1887

can´t attach a screenshot currently, so here is the faulty sample

"card007_ProductsOutOfStock": {
  "model": "salesOrder",
  "template": "sap.ovp.cards.stack",
  "settings": {
    "itemText": "{{stackCard_itemText}}",
    "title": "Products Out of Stock",
    "subTitle": "SalesOrderSet Stack Card",
    "requireAppAuthorization": "#Action-toappnavsample",
    "entitySet": "SalesOrderSet",
    "identificationAnnotationPath": "com.sap.vocabularies.UI.v1.Identification,com.sap.vocabularies.UI.v1.Identification#item2",
    "objectStreamCardsSettings": {
      "showFirstActionInFooter": false,
      "customActions": [
        {
          "text": "text1",
          "press": "press1",
          "position": 1
        },
        {
          "text": "text2",
          "press": "press2",
          "position": 10
        },
        {
          "text": "text3",
          "press": "press1",
          "position": 3
        },
        {
          "text": "text4",
          "press": "press2",
          "position": 8
        },
        {
          "text": "text5",
          "press": "press1",
          "position": 5
        },
        {
          "text": "text6",
          "press": "press2",
          "position": 6
        }
      ]
    }
  }
}, 
DavidMitreski5 commented 1 year ago

Hi @marianfoo, Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

KvM2 commented 1 year ago

This is actually an FE topic. I reassigned it now.

JannaLisa commented 1 year ago

Hi @marianfoo , just a quick update: this awful rendering of the sample seems to have occurred with version 1.110 - without us having changed anything. So since I'm unable to identify any cause, the only thing I can do is manually correct the sample code again. The corrected version will be visible with release 1.113, since release 1.112 has already been closed. Thanks for spotting this. Best regards, JannaLisa

OlMue commented 1 year ago

Closing this since it's solved. Thanks again, @marianfoo!

sap-doc-bot[bot] commented 7 months ago

Thank you for your valuable feedback contribution, @marianfoo! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

marianfoo commented 6 months ago

https://people.sap.com/mariannnn