SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
72 stars 119 forks source link

Update creating-a-simple-square-control-9a6100b.md #51

Closed dexter0175 closed 1 year ago

cla-assistant[bot] commented 1 year ago

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

KvM2 commented 1 year ago

Hi @dexter0175 , thanks for your contribution. We appreciate it and will look into this.

boghyon commented 1 year ago

Good catch! The current renderer definition there is indeed syntactically wrong which could be fixed with this PR. It would be better if at least apiVersion: 2 or apiVersion: 4 could be added to the renderer object.

Without the explicit apiVersion 2 or higher, the control will be rendered string-based bypassing the efficient DOM-patching: https://github.com/SAP/openui5-docs/issues/33


Generally, the UI5 rendering topic is a mess at the moment. See the "Motivation" section at https://github.com/SAP/openui5-docs/issues/17. But that's a different issue..

KvM2 commented 1 year ago

Thanks for your patience - I will get back to you on this.

sap-doc-bot[bot] commented 1 year ago

Thank you for your valuable content contribution, @dexter0175! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

KlattG commented 1 year ago

Hi @dexter0175 , thanks for your contribution. The issue will be fixed with UI5 1.115