SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
72 stars 119 forks source link

Fix unquoted property names with dashes #83

Closed akudev closed 8 months ago

akudev commented 9 months ago

The existing syntax is invalid. Dashes outside strings are considered "minus" characters.

Please look for other places.

cla-assistant[bot] commented 9 months ago

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] commented 9 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

OlMue commented 9 months ago

Thanks, @akudev! @KvM2, let's check how we can look for other instances of this.

akudev commented 9 months ago

Actually it seems to be the only instance of this problem in this repo: https://github.com/search?q=repo%3ASAP-docs%2Fsapui5+%2F%5E%5Cs%2B%5Cw%2B-%5Ba-zA-Z0-9-%5D*%3A%5Cs*%22%2F&type=code

KvM2 commented 8 months ago

Hi @akudev, Thanks for your contribution. I have adapted the documentation for 1.120.

sap-doc-bot[bot] commented 8 months ago

Thank you for your valuable content contribution, @akudev! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

akudev commented 8 months ago

https://people.sap.com/andreas.kunz