Walkthrough Step 28 not complete

SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.

Creative Commons Attribution 4.0 International

79 stars 126 forks source link

Walkthrough Step 28 not complete #9

Closed thunermay closed 1 year ago

thunermay commented 1 year ago

When programming the Walkthrough Step 28, there is something missing. In the NavigationJourney.js there are 4 steps:

Given: iStartMyUiComponent
When: onTheAppPage.iPressSayHelloWithDialogButton
Then: onTheAppPage.iShouldSeeTheHelloDialog
Then: iTearDownMyApp The problem is that after this there are only 2 of the 4 implemented (in pages/App.js) because of this, the test does not work according to the walkthrough Please add those two steps so that the test works thanks

KvM2 commented 1 year ago

Hello , thanks for your contribution! We really appreciate it and will look into this .

KlattG commented 1 year ago

Hello @thunermay , the 2 methods you're missing in pages/App.js are provided by OPA and don't have to be implemented there. If your test is failing, the reason should be somewhere else. Therefore I'm closing this issue.

sap-doc-bot[bot] commented 9 months ago

Thank you for your valuable feedback contribution, @thunermay! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

thunermay commented 8 months ago

https://people.sap.com/test12345678901234567890