search

SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
71 stars 116 forks source link

[doc issue] Missing modification in Step 4: Two-Way Data Binding for file index.html #94

Closed hhelibeb closed 6 months ago

hhelibeb commented 7 months ago

Issue description

I discovered an omission in Tutorial Step 4: Two-Way Data Binding. There is an essential modification in the index.html file, the attribute data-sap-ui-resourceroots , which is present in the provided code sample but not described in the tutorial text. This omission leads to exception when following the code provided in the tutorial. There is no data-sap-ui-resourceroots in step 3, 图片 but we can find it in step 4, 图片

Please consider updating the tutorial to include the missing modification found in the index.html file.

Feedback Type (Optional)

content gaps

Page Title on SAP Help Portal (prefilled)

Step 4: Two-Way Data Binding

Page URL on SAP Help Portal (prefilled)

https://sapui5.hana.ondemand.com/sdk/#/topic/c72b922fdb59422496661000165d7ff1

sap-doc-bot[bot] commented 7 months ago

Thank you for your valuable feedback contribution, @hhelibeb! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

KlattG commented 6 months ago

Hi @hhelibeb , thanks for pointing this out. We agree that the description should be improved and decided to fix the issue as part of an upcoming general revision of the Data Binding tutorial and sample code.

We close this issue for the time being and let you know once we've revised the tutorial.

KlattG commented 3 months ago

Hi @hhelibeb , thanks again for your contribution. I just wanted to let you know that we've now revised the tutorial and fixed the issue as of UI5 1.122