SAP-docs / sapui5

This is the markdown version of the official SAPUI5 documentation from the SAPUI5 Demo Kit for external contributions.
Creative Commons Attribution 4.0 International
71 stars 116 forks source link

Update step-26-mock-server-configuration-bae9d90.md #98

Closed caiwenhn2008 closed 7 months ago

caiwenhn2008 commented 7 months ago

missing =>

cla-assistant[bot] commented 7 months ago

CLA assistant check
All committers have signed the CLA.

flovogt commented 7 months ago

@caiwenhn2008 thanks for creating this issue. Using just a simple method definition should be fine here. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions

Any benefits of using arrow function here?

caiwenhn2008 commented 7 months ago

@caiwenhn2008 thanks for creating this issue. Using just a simple method definition should be fine here. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions

Any benefits of using arrow function here?

Thanks for quick response, below screenshot is what I saw from https://sapui5.hana.ondemand.com/sdk/#/topic/bae9d90d2e9c4206889368f04edab508 , and I failed when running this sample due to extra colon

image

is there any github synch issue here? I think we can either remove ":" or change to " init: () => {" "

flovogt commented 7 months ago

Ok, i just figured out that I have fixed it already.

See here https://sdk.openui5.org/nightly/#/topic/bae9d90d2e9c4206889368f04edab508

@KlattG could you please check if the fix is also present in the last 1.120 version?

caiwenhn2008 commented 7 months ago

Yes, nightly fixed, thanks!

OlMue commented 7 months ago

@KlattG could you please check if the fix is also present in the last 1.120 version?

Just checked it, it's fixed in 1.120.2.

sap-doc-bot[bot] commented 7 months ago

Thank you for your valuable content contribution, @caiwenhn2008! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!