SAP-samples / abap-platform-refscen-flight

SFlight is back! This is the Flight Reference Scenario for the ABAP RESTful Application Programming Model.
Apache License 2.0
230 stars 93 forks source link

Failure to import 2023 Branch #36

Open mydoghasfleas opened 4 months ago

mydoghasfleas commented 4 months ago

My second attempt at importing the 2023 Branch failed.

Extensive report created as an issue on abapGit, but the question is, if you managed to successfully create the package with abapGit, why would it not work on our S/4 HANA 2023 system?

Please refer to the below:

https://github.com/abapGit/abapGit/issues/6927

(If you like, I can repost everything here).

mydoghasfleas commented 3 months ago

On our on-prem S/4 HANA 2023 system, I am importing the 2023 branch of the flight model demo (https://github.com/SAP-samples/abap-platform-refscen-flight) from an exported zip file, as our system is blocked by the firewall from accessing github.com.

This time, instead of using the version of the standalone abapGit program shipped with our S/4 HANA system, I have downloaded and installed the latest (1.128.0) and used that.

After apparently successfully importing and activating all objects, I still am missing some, like the number range objects contained in the package (e.g. /DMO/AGNCY).

I am experiencing the same issue as reported here: https://github.com/SAP-samples/abap-platform-refscen-flight/issues/26.

I can confirm that I see the number range objects listed when I pull from the local repository (zip), after checking they are in the repository too.

So I decide to pull again and am surprised that there are many other objects listed that would apparently be created (again):

image

Including the NROs:

image

To be safe, I first deselect everything and try (re)import only the NROs.

Again, this is apparently successful, but still the NROs are not created in our system.

image

(I'm pretty sure I saw it try deserialize someting other than those objects too, but I can't say 100% for sure).

I will not go further at this point as perhaps you can advise me on the best course of action, before I break something.

mydoghasfleas commented 3 months ago

Strangely, I now see some objects not yet activated.

image

I choose Advanced -> Activate Objects, like before, and this time get a popup with a whole bunch of objects to activate.

image

Then I get a whole bunch of errors:

image

I think I will exit the program first to release those locks. Clicking back brings up the activation dialog again. I continue, and this time itself reports the errors:

image

So I cancel, and at this point, it is still doing something, I do not know what:

image

mydoghasfleas commented 3 months ago

OK, so after getting out, I went back in to try and load the repo from the zip again.

By the way, when I created the offline repo this time, the name was somehow not adopted:

image

Now I am ready to pull again from the zip, but is it safe to try import all these objects?

image

image

This time, I throw caution to the wind and proceed with these objects. (I don't know what object type DDLX or SRVB is, but I do not see it in the dropdown in the TADIR selection either).

The question is of course, why did they not get pulled the first time?

Now I try activate again, but it stops (no object list dialog this time, by the way):

image

mydoghasfleas commented 3 months ago

OK, so I have repeated documenting my experience here, copying everything from https://github.com/abapGit/abapGit/issues/6927.

mbtools commented 3 months ago

Re: Folder logic

The repo is using PREFIX (see .abapGit.xml. To avoid issues, you should use the same when creating the repo in your system. Also keep "Ignore subpackages" off.