search

SAP-samples / cap-bookshop-wdi5

Sample SAP Fiori application based on SAP Cloud Application Programming Model used in the associated SAP tutorial for developers.
https://developers.sap.com/tutorials/cicd-wdi5-cap.html
Apache License 2.0
10 stars 47 forks source link

Add node 18 engine #25

Closed o-liver closed 1 year ago

o-liver commented 1 year ago

When running the wdi5 tests with the SAP Continuous Integration and Delivery service it does not work out of the box unless setting the engine to node 18. We followed this tutorial: https://developers.sap.com/tutorials/cicd-wdi5-cap.html

o-liver commented 1 year ago

@Siolto Does this make sense?

Siolto commented 1 year ago

@Siolto Does this make sense?

thanks for the fix! As node 16 will be out of maintenance end of September I would directly move to node 18

o-liver commented 1 year ago

@Siolto This needs to be added to the solution branch as well, right?