search

SAP-samples / cloud-cap-samples-java

A sample application that demonstrates the features of the Java SDK for the SAP Cloud Application Programming Model.
https://cap.cloud.sap
Apache License 2.0
142 stars 142 forks source link

Don't hardcode `java` build task #389

Closed swaldmann closed 1 week ago

swaldmann commented 2 weeks ago

In the sample here and in cds add sample the srv/pom.xml build task is hardcoded to java.

It would imo be better to simply use cds build --production, as the build itself can determine which plugin to run based on the context.

This hardcoded approach doesn't work with build plugins, for example for the AMS integration. The plugin is automatically pulled for cds build --production but left out when the java build task is explicitly specified.

@mofterdinger @beckermarc

swaldmann commented 1 week ago

Discussing different solution, closing this PR