search

SAP-samples / cxii-visual-search-ui-component

SAP CX Visual Search UI component is an extension of SAP Commerce Cloud, composable storefront. This is a reference implementation for customers to use as a library or other custom implementations.
Apache License 2.0
2 stars 0 forks source link

npm install fails with 401 #9

Open cdavidowski opened 2 months ago

cdavidowski commented 2 months ago

While following the instructions in the readme to run 'npm install' under the projects/visualsearch folder, I encounter a 401 error when trying to pull spartacus/user from https://common.repositories.cloud.sap/artifactory/api/npm/deploy-releases-hyperspace-npm/@spartacus/user/-/@spartacus/user-5.2.1.tgz. This is due to common.repositories.cloud.sap being a private repository.

I am able to resolve this error if i configure a .npmrc file with information to connect to RBSC per the Composable Storefront instructions, delete the package-lock.json file and run npm install again.

Is this the correct way to build this package?

cdavidowski commented 2 months ago

I felt uneasy about updating the dependencies outside of the ones you released in package-lock.json.

I updated the spartacus dependencies to use the urls and checksums from the RBSC.

I'm still able to run 'npm install' successfully. It may be good to update the readme with instructions for building this for non-SAP employees.

Here's the output from gitdiff for those sections

@@ -504,8 +504,8 @@
     },
     "node_modules/@spartacus/cart": {
       "version": "5.2.1",
-      "resolved": "https://common.repositories.cloud.sap/artifactory/api/npm/deploy-releases-hyperspace-npm/@spartacus/cart/-/@spartacus/cart-5.2.1.tgz",
-      "integrity": "sha512-uzlKPTnMklwfTR5yi2TfXon1cQNAsi2OTWhWd7opmXfqOZb/OttikmnlbXnHTvcTCoKHOUUaRL6VHqH97SPFkA==",
+      "resolved": "https://73554900100900004337.npmsrv.base.repositories.cloud.sap/nexus3/repository/npm73554900100900004337/@spartacus/cart/-/cart-5.2.1.tgz",
+      "integrity": "sha512-OS/KdWZuHzATsn4+j1DCDFp1lWjO3o13y9scXBOtPlj6v8uhtFaPo60vbUKZoWiJ+whCg+Sj7dIaTVIeeKYrWA==",
       "dev": true,
       "dependencies": {
         "tslib": "^2.4.0"
@@ -530,8 +530,8 @@
     },
     "node_modules/@spartacus/core": {
       "version": "5.2.1",
-      "resolved": "https://common.repositories.cloud.sap/artifactory/api/npm/deploy-releases-hyperspace-npm/@spartacus/core/-/@spartacus/core-5.2.1.tgz",
-      "integrity": "sha512-93iwqClZMCfa83MMaTY7Krfem9xbZLS5djVdup15dLFXolEgwzAL5C2dFLD8g4U9cDO0pEf0UBHTPlyRK7N5ug==",
+      "resolved": "https://73554900100900004337.npmsrv.base.repositories.cloud.sap/nexus3/repository/npm73554900100900004337/@spartacus/core/-/core-5.2.1.tgz",
+      "integrity": "sha512-tVics8XpxJqO3qrr2jE3SZW7lZivmWqWnS/NbDMzuudl3c56g60m6W1EE4ayqg6ztS2jCL715Aq1edlwfiHRvg==",
       "dev": true,
       "dependencies": {
         "tslib": "^2.4.0"
@@ -552,8 +552,8 @@
     },
     "node_modules/@spartacus/schematics": {
       "version": "5.2.1",
-      "resolved": "https://common.repositories.cloud.sap/artifactory/api/npm/deploy-releases-hyperspace-npm/@spartacus/schematics/-/@spartacus/schematics-5.2.1.tgz",
-      "integrity": "sha512-g9rPFPDIzOabxA84VmDvQMWdw9ED/1jHmGS9+9/OX50WTZuo8adiAbEcoXxv17BYXUfEVmylEB9Omn53uTMeFA==",
+      "resolved": "https://73554900100900004337.npmsrv.base.repositories.cloud.sap/nexus3/repository/npm73554900100900004337/@spartacus/schematics/-/schematics-5.2.1.tgz",
+      "integrity": "sha512-eZq9r5FkzDMx9GnPeoU2BWAMHS+PmT9Si4M5+zqeOyy1S2efKiCDpXzZnyohfOqtrTwIkPm+FGFqWVWwOr8U1w==",
       "dev": true,
       "peer": true,
       "dependencies": {
@@ -580,8 +580,8 @@
     },
     "node_modules/@spartacus/storefront": {
       "version": "5.2.1",
-      "resolved": "https://common.repositories.cloud.sap/artifactory/api/npm/deploy-releases-hyperspace-npm/@spartacus/storefront/-/@spartacus/storefront-5.2.1.tgz",
-      "integrity": "sha512-NnHKDYavgJg8O+2ySLAZOA/CF5FLv6vJVLZo5paBxMLhU8/WafwRgLNm3X+Pn1wTmmCe1DtGyt2OEOTrbl/CCw==",
+      "resolved": "https://73554900100900004337.npmsrv.base.repositories.cloud.sap/nexus3/repository/npm73554900100900004337/@spartacus/storefront/-/storefront-5.2.1.tgz",
+      "integrity": "sha512-RQ4GUtdmcmtAu8ADNm17G23tBU3FTDaYcWS7jaBreEnYLRDPk5ufYI9d6C7cmBrekcfnAtJP7FKaMqzFsNGY6g==",
       "dev": true,
       "dependencies": {
         "tslib": "^2.4.0"
@@ -604,8 +604,8 @@
     },
     "node_modules/@spartacus/styles": {
       "version": "5.2.1",
-      "resolved": "https://common.repositories.cloud.sap/artifactory/api/npm/deploy-releases-hyperspace-npm/@spartacus/styles/-/@spartacus/styles-5.2.1.tgz",
-      "integrity": "sha512-5pduY+fchNr14FDz4zCmIaekaiy9XLQuwrQ+TFlIZtcIlTxPZYqdXl0nabOMhMnCZfAz0X136P3fzwaZkamCng==",
+      "resolved": "https://73554900100900004337.npmsrv.base.repositories.cloud.sap/nexus3/repository/npm73554900100900004337/@spartacus/styles/-/styles-5.2.1.tgz",
+      "integrity": "sha512-eHNpe/1kFdFdICMtAsE6DEFCnLySwdfHWmIrk004kANCLAIwVCf3f0EHaI8280ayoRcfAAu6aGsZJE2NgNzUXQ==",
       "dev": true,
       "peer": true,
       "dependencies": {
@@ -618,8 +618,8 @@
     },
     "node_modules/@spartacus/user": {
       "version": "5.2.1",
-      "resolved": "https://common.repositories.cloud.sap/artifactory/api/npm/deploy-releases-hyperspace-npm/@spartacus/user/-/@spartacus/user-5.2.1.tgz",
-      "integrity": "sha512-YDhsUT4T5ddlj0EC98vlBckzF9IBQqTlRa6nqaYnOdYFm/UsWP2r03BL446fx/enP0r+pjhaJ6y7xc3nMfVA4g==",
+      "resolved": "https://73554900100900004337.npmsrv.base.repositories.cloud.sap/nexus3/repository/npm73554900100900004337/@spartacus/user/-/user-5.2.1.tgz",
+      "integrity": "sha512-lcHS4LCpTJLFYsCJp1M5VSwOMye3v4V6nDrTOlXFH0/iqgABHr12uLWNB6RsNV1K6K2lOQyVJieHmdyHLTeQ1Q==",
       "dev": true,
       "peer": true,
       "dependencies": {