search

SAP-samples / hana-developer-cli-tool-example

Learn how to build a developer-centric SAP HANA command line tool, particularly designed to be used when performing SAP HANA development in non-SAP tooling (for example from VS Code).
Apache License 2.0
90 stars 24 forks source link

DECIMAL type without decimals generates CDS error (inspectTable) #29

Closed ThePlenkov closed 3 years ago

ThePlenkov commented 3 years ago

Hi!

If we have a column like that image

inpectTable gives us file like this: image

I'll use same PR #28 to fix it

ThePlenkov commented 3 years ago

@jung-thomas spec says scale is optional. What do you think to write better in this case Decimal(34) or Decimal(34,0)? Thanks

ThePlenkov commented 3 years ago

fixed in #28

jung-thomas commented 3 years ago

Confirmed fixed