SAP-samples / hana-developer-cli-tool-example

Learn how to build a developer-centric SAP HANA command line tool, particularly designed to be used when performing SAP HANA development in non-SAP tooling (for example from VS Code).
Apache License 2.0
90 stars 24 forks source link

adminHDI grants privileges to SYSTEM #74

Closed jung-thomas closed 2 years ago

jung-thomas commented 2 years ago

adminHDI.js creates a new user and grants the privileges from _SYS_DI.T_DEFAULT_DI_ADMIN_PRIVILEGES to this user. In addition these privileges are also always granted to SYSTEM. Is this the expected behavior or should it be fixed? Not an issue for my use case, so I'm fine with keeping it as it is.

At the very least the grant to the Built-In Admin user should be optional and default to false. But it should also be smart enough to target SYSTEM in on premise and DBADMIN in Cloud.