SAP-samples / hana-hdbext-promisfied-example

Example of how to use @sap/hdbext (standard node.js SAP HANA interface) via a promisfied wrapper.
Apache License 2.0
13 stars 8 forks source link

Unable to call procedures with decimals in their name #16

Closed jkirsons closed 1 year ago

jkirsons commented 1 year ago

When loading/calling a procedure with characters like decimals such as: company.project_db.procedures::proc_RUN_L0

The procedure needs to be in double quotes for the CALL statement to succeed, however the call to fetchSPMetadata needs the procedure to not have double quotes for it to be able to find the procedure to get it's parameters.

Can you change this line: https://github.com/SAP-samples/hana-hdbext-promisfied-example/blob/fccf5bae488f7b964f5625fa761bfa55184236ce/hdb/index.js#L270

to: return this.preparePromisified(CALL ${schema}."${procedure}"(${callString}))

placing double quotes around the procedure name?

jung-thomas commented 1 year ago

Thanks for the report and the solution. I've integrated this fix, tested and pushed it to npm.