search

SAP-samples / hana-shine-xsa

SAP HANA Interactive Education for SAP HANA Extended Application Services, Advanced Model (SHINE for XS Advanced) is an education content to learn, develop, and deploy SAP HANA XS Advanced Model application and is a successor of SHINE for XS Classic.
Apache License 2.0
115 stars 111 forks source link

SAP artifact in the httpclient.js file #35

Closed jonathanbaker7 closed 5 years ago

jonathanbaker7 commented 6 years ago

The file httpClient.js contains a reference to an internal SAP server:

        {path: "http://www.loc.gov/pictures/search/?fo=json&q=SAP&",
    host: "proxy.wdf.sap.corp",
    port: "8080",
    headers: {
        host: "www.loc.gov"

Specifically, the server:

proxy.wdf.sap.corp

This artifact won't work outside the SAP firewall.

SAP Open Source runs regular scans looking for artifacts in the code which might indicate our internal code has accidentally released in to the Open Source stream. This file continues to show up in our scans. Can you please fix it, or remove it, so that it no longer shows up as an error?

Thank you.

LakshmiCR commented 5 years ago

Hi,

This has been removed in the latest code. Thank you for letting us know.

Thanks and Regards, Lakshmi