search

SAP-samples / hana-shine-xsa

SAP HANA Interactive Education for SAP HANA Extended Application Services, Advanced Model (SHINE for XS Advanced) is an education content to learn, develop, and deploy SAP HANA XS Advanced Model application and is a successor of SHINE for XS Classic.
Apache License 2.0
115 stars 111 forks source link

take audit log service name from environment, which is fed by mta #50

Closed ariel-bentu closed 5 years ago

ariel-bentu commented 5 years ago

The way it is ow, is hard coded, which makes it hard to deploy in development environment, because it mandates that the name of the instance is shine-audit-log and cannot be developer-specific

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Ariel Bentolila seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CHERIANS commented 5 years ago

Thanks for feedback. We will fix it. We don't accept Pull Request. So will close this request